-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added examples as a subdirectory #706
Conversation
67464a6
to
1b4777f
Compare
Please rename it to
Can you fix them? |
Hey @hossein-zare,
Okay, I'll rename the subdirectory from
Do you mean to move the example source files into different folders? There are four of them, so I'm not sure if that would be useful, if that is what you mean.
You're welcome, no problem.
I'll have a go, but I'm not sure if it makes sense. Maybe it is something that should be fixed in the library: for something so simple and "out of the box", should you have to use |
It would be good if you create separate folders for each of them,
|
Hey @hossein-zare,
I'm not sure what structure you mean. At the moment, four source files implement each example. Two are written in JavaScript and two in TypeScript. Two are class components and two are function components. They're all in the
Yes, as in you think it should be necessary to use Why do you mention the Avoid inappropriate styles rule? Are you saying my |
As an example, for the
No, Not a usage rule. When you encounter issues that can be fixed by using zIndex.
No, I said it generally because sometimes not using |
Ah ok, I see what you mean! I think the PR is now ready to be merged. If you disagree and think more changes should be made, please let me know :) |
Yes, mergeable. |
@hossein-zare I've added the examples in the
rndp-examples
subdirectory and updated the README to mention it. There are the common zIndex/overlapping issues, but it otherwise works. It should only take a couple of minutes to look at it, so I'll leave this PR open for a little while in case you want to. If you do, please let me know if you're happy with the new examples or if you'd suggest any changes. Thanks!